Add support for leaf2 and leaf4 on Intel's x86 arch#80
Merged
Conversation
fexolm
changed the title
psiegl
reviewed
Jun 25, 2019
| return MakeX86CacheLevelInfo(-1, PREFETCH, 128, -1, -1, -1, 0); | ||
| case 0xFF: | ||
| return MakeX86CacheLevelInfo(-1, EMPTY, -1, -1, -1, -1, 0); | ||
| } |
Contributor
There was a problem hiding this comment.
wouldn't it be possible to make a table of structs out of it that hosts the parameters?
Collaborator
There was a problem hiding this comment.
wouldn't it be possible to make a table of structs out of it that hosts the parameters?
I fail to see how a table of structs makes it simpler. Once you have the table you still need to index it.
Did I miss something?
Contributor
Author
There was a problem hiding this comment.
I'm not sure how it can be simplified. If you have any suggestions, I can implement them.
gchatelet
reviewed
Jun 26, 2019
Contributor
Author
|
@gchatelet, @psiegl Thanks for the review. Must be fixed now. PTAL. |
gchatelet
reviewed
Jul 2, 2019
Contributor
Author
|
@gchatelet, fixed, PTAL |
Collaborator
LGTM. Thx! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.